search

gitextensions / gitextensions.pluginmanager

Package manager for downloading and installing Git Extensions plugins.
MIT License
13 stars 10 forks source link

place all plugins in sub-directories #31

Closed mast-eu closed 5 years ago

mast-eu commented 5 years ago

Closes #29.

Proposed changes

The new directory structure is:

UserPlugins\
    GitExtensions.PluginManager\
        PackageManager\PackageManager.UI.exe
        GitExtensions.PluginManager.dll
    GitExtensions.SVN\
        GitExtensions.SVN.dll
    NuGet.Config
    packages.config

Opposed to the old structure:

UserPlugins\
    PackageManager\PackageManager.UI.exe
    GitExtensions.PluginManager.dll
    GitExtensions.SVN.dll
    NuGet.Config
    packages.config
RussKie commented 5 years ago

The original code was designed to be reusable and so there are many command line arguments. Do we want to maintain it here or are we going to simplify there things?

Not now. We need to release 3.2. We can simplify things later

mast-eu commented 5 years ago

Do we want to maintain it here or are we going to simplify there things?

Let's say for the moment I'm happy if you can confirm that I changed all relevant paths in a consistent way, without breaking existing functionality.

I tested install, re-install and uninstall with GitExtensions.SVN, but obviously you know the code much better than I do.

mast-eu commented 5 years ago

I tested install, re-install and uninstall with GitExtensions.SVN

Now I tested also the update mechanism and realized there's at least one more file that needed to be modified: https://github.com/gitextensions/gitextensions.pluginmanager/pull/31/files#diff-bdfb0c9828513b725508b6dab2d3e3f5

@maraf I think I went through all possible commands: install, re-install, update and uninstall. All of those with a single and with multiple packages at once. Do I still miss something?

maraf commented 5 years ago

@mast-eu I think you catched them all.