search

gitextensions / gitextensions.pluginmanager

Package manager for downloading and installing Git Extensions plugins.
MIT License
13 stars 10 forks source link

Modify setting to close GE #35

Open mast-eu opened 5 years ago

mast-eu commented 5 years ago

There's a setting to close GE as soon as PM is started: image

IMHO, it is valid to have an option to avoid this popup when a user installs a plugin: image

However, the current implementation seems a bit "exaggerated". It always shuts down GE straight away when PM is started, even if the user doesn't install any plugin. Maybe I just clicked the plugin by accident....

I propose to change this into something like "Automatically close Git Extensions when installing plugins (don't ask for confirmation)". The default value should remain false.

RussKie commented 5 years ago

I propose to reword to: Automatically close Git Extensions when installing plugins. I would also suggest to make the setting or the value visible on the UI somehow (e.g. as a status message). Or confirm with a user whether the user wishes to close all GE instances once plugins are installed/updated.

A really cool thing to do - would to restart all GE instances as they were. We could enumerate available processes and relaunch GE with the same settings. This of course isn't 100% reliable, if a user opened GE with one repo and then switched to another, the start parameters will have the first repo info.

Slightly OT - the setting looks ugly. Its placement looks somewhat random, the text is misaligned with the checkbox. And the checkbox is to the right of the text, contrary to all other checkbox settings: image

ghost commented 4 years ago

How do I find these settings?

image

RussKie commented 4 years ago

How do I find these settings?

Which one, sorry?

ghost commented 4 years ago

image

RussKie commented 4 years ago

The list on the left is build dynamically from the PluginRegistry (I think). The one of the right - no idea :) I don't have access to the source right now.

ghost commented 4 years ago

Plugin manager is installed. But there are no settings.

maraf commented 4 years ago

I can confirm the settings disappeared for Plugin Manager.

maraf commented 4 years ago

Now I remenber, in Git Extensions v3.3.1 added protected ctor with bool hasSettings. We are not using it in Plugin Manager yet.

mast-eu commented 4 years ago

in Git Extensions v3.3.1 added protected ctor with bool hasSettings. We are not using it in Plugin Manager yet.

For future reference: This has been added in #43. The PR is merged into master, but not yet included in a release.