Migration to .NET 5 - Githubissues

gitextensions / gitextensions.pluginmanager

Package manager for downloading and installing Git Extensions plugins.

MIT License

13 stars 10 forks source link

Migration to .NET 5 #58

Closed maraf closed 3 years ago

maraf commented 3 years ago

Replaced costura with .NET single file publish.
Fixed package source ordering in Nuget.PackageManagement-v5.11.0.
Updated release script.

Fixes #57.

RussKie commented 3 years ago

I'm testing the .NET 5.0 release, and the Plugin Manager is failing to start with the following error:

Description: A .NET application failed.
Application: PackageManager.UI.exe
Path: D:\Development\gitextensions\artifacts\Release\publish\GitExtensions-Portable-33.33.33.0-0af3f84d3\UserPlugins\GitExtensions.PluginManager\PackageManager\PackageManager.UI.exe
Message: The application to execute does not exist: 'D:\Development\gitextensions\artifacts\Release\publish\GitExtensions-Portable-33.33.33.0-0af3f84d3\UserPlugins\GitExtensions.PluginManager\PackageManager\PackageManager.UI.dll'.

It looks like it is looking for PackageManager.UI.dll, and there's only a PackageManager.UI.exe....

RussKie commented 3 years ago

You can grab build artifacts here: https://ci.appveyor.com/project/gitextensions/gitextensions/builds/41427744/artifacts, or use the branch if you want to build it locally: https://github.com/gitextensions/gitextensions/tree/msi

maraf commented 3 years ago

@RussKie Are you using MSI or portable? Because with portable from the link about it seems the PM is working (it shows an error with reading settings, but the PM starts and works).

I struggling to run the installer on sandbox machine. I have there .NET 5.0.12 runtime, but it still says that I don't and clicking yes does nothing. Anyway, the portable version runs there...

maraf commented 3 years ago

💡 Also, the installer and portable still contains an previous PM version (1.1.0.109). So, I think we need to first release the PM v2.0 and than we can test the GE installer. Correct?

gerhardol commented 3 years ago

https://github.com/gitextensions/gitextensions/pull/9704 to build installer with msbuild explicitly (but I do not get it built myself)

RussKie commented 3 years ago

I built the msi locally having downloaded the latest version of the PM manually. Then installed the msi.

On Tue, 9 Nov 2021, 8:01 am Gerhard Olsson, @.***> wrote:

gitextensions/gitextensions#9704 https://github.com/gitextensions/gitextensions/pull/9704 to build installer with msbuild explicitly (but I do not get it built myself)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gitextensions/gitextensions.pluginmanager/pull/58#issuecomment-963568690, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBTEXQDIDNNWNBVQ6SS343ULA3BHANCNFSM5HDVRPHQ .

maraf commented 2 years ago

I probably found the problem. The build on AppVeyor doesn't work as locally.

Size of these artifacts should be about 4MB.

The problem is with single file publish of PackageManager UI. It seems it ignores the publish profile.

When I run the build script (Prepare-Release.ps1) locally, it produces correct artifacts.

@RussKie Any ideas?