gitextensions / gitextensions.vsix

Visual Studio extensions for Git Extensions
MIT License
16 stars 8 forks source link

VS2022 crashes when invoking 'Find file' #30

Open woutkroon opened 2 years ago

woutkroon commented 2 years ago

(I took the liberty of using the bug template from GitExtensions itself)

Environment

copy paste from VS2022 about: Microsoft Visual Studio Professional 2022 Version 17.0.4 VisualStudio.17.Release/17.0.4+32014.148 Microsoft .NET Framework Version 4.8.04084

Installed Version: Professional

Visual C++ 2022 00476-80000-00000-AA007 Microsoft Visual C++ 2022

.NET Core Debugging with WSL 1.0 .NET Core Debugging with WSL

ADL Tools Service Provider 1.0 This package contains services used by Data Lake tools

ASA Service Provider 1.0

ASP.NET and Web Tools 2019 17.0.795.42246 ASP.NET and Web Tools 2019

ASP.NET Web Frameworks and Tools 2019 17.0.795.42246 For additional information, visit https://www.asp.net/

Azure App Service Tools v3.0.0 17.0.795.42246 Azure App Service Tools v3.0.0

Azure Data Lake Tools for Visual Studio 2.6.4000.0 Microsoft Azure Data Lake Tools for Visual Studio

Azure Functions and Web Jobs Tools 17.0.795.42246 Azure Functions and Web Jobs Tools

Azure Stream Analytics Tools for Visual Studio 2.6.4000.0 Microsoft Azure Stream Analytics Tools for Visual Studio

C# Tools 4.0.1-1.21568.1+6ab6601178d9fba8c680b56934cd1742e0816bff C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools 1.10 Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Extensibility Message Bus 1.2.6 (master@34d6af2) Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.

Fabric.DiagnosticEvents 1.0 Fabric Diagnostic Events

GitExtensions 1.0 Git Extensions is a graphical user interface for Git that allows you to control Git without using the command-line

Microsoft Azure Hive Query Language Service 2.6.4000.0 Language service for Hive query

Microsoft Azure Service Fabric Tools for Visual Studio 17.0 Microsoft Azure Service Fabric Tools for Visual Studio

Microsoft Azure Stream Analytics Language Service 2.6.4000.0 Language service for Azure Stream Analytics

Microsoft Azure Tools for Visual Studio 2.9 Support for Azure Cloud Services projects

Microsoft JVM Debugger 1.0 Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft Library Manager 2.1.134+45632ee938.RR Install client-side libraries easily to any web project

Microsoft MI-Based Debugger 1.0 Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual C++ Wizards 1.0 Microsoft Visual C++ Wizards

Microsoft Visual Studio Tools for Containers 1.2 Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container.

Microsoft Visual Studio VC Package 1.0 Microsoft Visual Studio VC Package

Mono Debugging for Visual Studio 17.0.11 (54f19d2) Support for debugging Mono processes with Visual Studio.

NuGet Package Manager 6.0.1 NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

ProjectServicesPackage Extension 1.0 ProjectServicesPackage Visual Studio Extension Detailed Info

Razor (ASP.NET Core) 17.0.0.2156603+e9cd763349a080127b6519ffbec0123949a4c385 Provides languages services for ASP.NET Core Razor.

SQL Server Data Tools 17.0.62110.20190 Microsoft SQL Server Data Tools

Test Adapter for Boost.Test 1.0 Enables Visual Studio's testing tools with unit tests written for Boost.Test. The use terms and Third Party Notices are available in the extension installation directory.

Test Adapter for Google Test 1.0 Enables Visual Studio's testing tools with unit tests written for Google Test. The use terms and Third Party Notices are available in the extension installation directory.

ToolWindowHostedEditor 1.0 Hosting json editor into a tool window

TypeScript Tools 17.0.1001.2002 TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools 4.0.1-1.21568.1+6ab6601178d9fba8c680b56934cd1742e0816bff Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools 17.0.0-beta.21522.2+6d626ff0752a77d339f609b4d361787dc9ca93a5 Microsoft Visual F# Tools

Visual Studio Code Debug Adapter Host Package 1.0 Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

Visual Studio Container Tools Extensions 1.0 View, manage, and diagnose containers within Visual Studio.

Visual Studio IntelliCode 2.2 AI-assisted development for Visual Studio.

Visual Studio Tools for CMake 1.0 Visual Studio Tools for CMake

Visual Studio Tools for Containers 1.0 Visual Studio Tools for Containers

VisualStudio.DeviceLog 1.0 Information about my package

VisualStudio.Foo 1.0 Information about my package

VisualStudio.Mac 1.0 Mac Extension for Visual Studio

Xamarin 17.0.0.343 (d17-0@fb07a17) Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin Designer 17.0.0.183 (remotes/origin/d17-0@a351f0f1f) Visual Studio extension to enable Xamarin Designer tools in Visual Studio.

Xamarin Templates 17.0.17 (9e779b0) Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms.

Xamarin.Android SDK 12.1.0.5 (d17-0/6b0e6b2) Xamarin.Android Reference Assemblies and MSBuild support. Mono: c633fe9 Java.Interop: xamarin/java.interop/d17-0@febb1367 ProGuard: Guardsquare/proguard/v7.0.1@912d149 SQLite: xamarin/sqlite/3.36.0@a575761 Xamarin.Android Tools: xamarin/xamarin-android-tools/d17-0@a5194e9

Xamarin.iOS and Xamarin.Mac SDK 15.4.0.0 (8fc41ae82) Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.

copy/paste from GitExtensions about:

Issue description:

Whenever I invoke the 'Find file' option from the GitExt menu, VS2022 almost instantly crashes. This happens both with a small solution (3 projects) as well as with a larger solution (111 projects). It happens both when VS2022 is started with elevated permissions (to debug) as well as when it is started with normal user permissions.

Three of my co-workers experience the same issue. They are working on identical workstations with (near) identical software configurations on the same type of solutions, connecting to the same Git repository.

Not sure whether this is relevant: I used the 'Customize Menu...' option under the Extensions menu to remove the checkmark for GitExt. This is needed to move the GixExt menu from the Extensions menu to its own spot in the main menu bar. Move GitExt menu

Steps to reproduce:

  1. Open VS2022 and open a solution that is located inside a Git repo.
  2. Invoke the 'Find file' option under the GitExt menu either by Alt+I and then L (keyboard shortcuts) or by clicking with the mouse. Invoke 'Find file'
  3. Notice how the cursor changes from an arrow to an arrow + blue spinning circle (busy indicator), almost instantly.
  4. Notice the standard Windows 'xxx has stopped working' dialog that pops up. VS2022 crash

Did this work in previous version of the GitExtensions plugin?

Yes, under VS2019 and with the previous version of the VSIX plugin (I have version 3.4.1.21 installed), opening the same solution/repo, etc. the 'Find file' option is working without issues.

Additional info

Please let me know if I should provide more information. If there are any logs that might be relevant. If there is any way to generate additional logging, etc. It would be great if this issue can be resolved!

Kind regards, Wout Kroon

gerhardol commented 2 years ago

Reproduced This command starts "GitExtensions.exe searchfile" that displays the searchdialog (as in FileTree) and writes the result to the console for VS to read. This works standalone. image

Not sure what is changed in VS2022 that do not allow the dialog to be shown.

I guess at least a timeout can be added, but how is this useful?

woutkroon commented 2 years ago

Hi @gerhardol, thanks for looking into this.

Are you asking me what the use for this 'Find file' command is? Or whether a timeout would be useful to prevent the crash?

gerhardol commented 2 years ago

Are you asking me what the use for this 'Find file' command is?

Yes

Or whether a timeout would be useful to prevent the crash?

That would just be a way to limit the impact (more a general change, if the command never works and cannot be fixed then it should be removed).

woutkroon commented 2 years ago

Me and my colleagues use the 'Find file' command to quickly find any file in the repository by name and open it in VS. We find that, for our purposes, it works faster and more accurate than the build-in search:

Search comparison

So it would be great if it could be fixed for VS2022. Less time searching for files == more time working on code. 😄

rizi commented 2 years ago

We have the same issue, just clicking on 'Find file' crashes VS 2022.

br