VS: Commit command is failing when the current tab is on a project properties

manuc66 commented 4 years ago

Current behaviour

It is impossible to launch the commit window in Visual Studio when the active document is a project properties.

Expected behaviour

The commit window should appear, allowing committing files

Steps to reproduce

Right click on a .Net project, choose properties Then click on the "Commit" button in the toolbar An error popup is triggered with the following message :

---------------------------
Microsoft Visual Studio
---------------------------
The parameter is incorrect. (Exception from HRESULT: 0x80070057 (E_INVALIDARG))
---------------------------
OK   
---------------------------

Other command affected:

Browse
Pull
Push
Stash
View changes
File history
...

Screenshots

Did this work in previous version of GitExtensions

Multiple release are probably affected

Environment

GitExtensions version:
GIT version: 2.27.0.windows.1
OS version: Microsoft Windows [Version 10.0.18363.900]
.NET version: .Net48

Diagnostics

vbjay commented 4 years ago

This is because it can't get a path from it.

manuc66 commented 4 years ago

@vbjay The extension https://github.com/heku/Kool.EditProject is able to edit the project of the current file and find its path. Maybe it might help to find a workaround.

vbjay commented 4 years ago

No. I mean the information from the editor of a code file is different than the project properties dialog. The same thing happens on the overview page when you start an asp .net project. It's the current active tab that gives us the context to commit from what. Sometimes the active tab doesn't have info we need.