search

gitextensions / gitextensions

Git Extensions is a standalone UI tool for managing git repositories. It also integrates with Windows Explorer and Microsoft Visual Studio (2015/2017/2019).
https://gitextensions.github.io/
Other
7.79k stars 2.09k forks source link

Default GPG tab to show #5527

Closed vbjay closed 5 years ago

vbjay commented 6 years ago

Do you want to request a feature or report a bug? bug What is the current behavior? The setting defaults to off. Setting is kind of buried.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

What is the expected behavior? Show GPG tab by default. Let user hide it if desired. Environment you encounter the issue:

Did this work in previous version of GitExtensions (which)? no

oriash93 commented 5 years ago

I started to work on it, but then found a possible bug and I need an approval.

The behavior of this setting is inconsistent. I turned it on (via the checkbox) and the GPG tab didn't show. I even closed the repository and opened it again, or opened a different repository, but the tab wasn't there.

Weirdly enough, when I changed the default setting to true, here:

https://github.com/gitextensions/gitextensions/blob/765888954ef07ae64fbdbfa4596edc37a6dd5763/GitCommands/Settings/AppSettings.cs#L367

it was on by default and the tab was there. However, when I turned it off (via the checkbox) the tab was still showing.

vbjay commented 5 years ago

You have to restart GE.

On Fri, Mar 1, 2019, 4:11 PM Ori Ashual notifications@github.com wrote:

I started to work on it, but then found a possible bug, and I need an approval.

The behavior of this setting is inconsistent. I turned it on (via the checkbox) and the GPG tab didn't show. I even closed the repository and opened it again, or opened a different repository, but the tab wasn't there.

Weirdly enough, when I changed the default setting to true, here:

https://github.com/gitextensions/gitextensions/blob/765888954ef07ae64fbdbfa4596edc37a6dd5763/GitCommands/Settings/AppSettings.cs#L367

it was on by default and the tab was there. However, when I turned it off (via the checkbox) the tab was still showing.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gitextensions/gitextensions/issues/5527#issuecomment-468813176, or mute the thread https://github.com/notifications/unsubscribe-auth/ADdhsf3OuUKv1sZDQ-p17ljn6sbit8kqks5vSZeXgaJpZM4XLUTa .

oriash93 commented 5 years ago

In that case, it should be mentioned that a restart is required (as in other settings in GE).

RussKie commented 5 years ago

In that case, it should be mentioned that a restart is required (as in other settings in GE).

This is good to fix, thanks for finding it