search

gitextensions / gitextensions

Git Extensions is a standalone UI tool for managing git repositories. It also integrates with Windows Explorer and Microsoft Visual Studio (2015/2017/2019).
https://gitextensions.github.io/
Other
7.81k stars 2.09k forks source link

Commit graph branch color continuity with show reflog is broken #5817

Open mdonatas opened 6 years ago

mdonatas commented 6 years ago

Do you want to request a feature or report a bug? Bug

What is the current behavior? A branch with show reflog references which has commits created in a non chronological order looks like christmas lights :)

image

What is the expected behavior? Continous color for a branch.

Environment you encounter the issue:

mdonatas commented 6 years ago

@spdr870 I couldn't repro this on spdr870/feature/graph_spdr870 @ 3efe3dba325e6178b7c256fa4297b409e2670730 it seems you've fixed it there with LaneInfo changes.

RussKie commented 6 years ago

Please try this build https://ci.appveyor.com/api/buildjobs/9uvt7cgl2v3e99om/artifacts/Setup%2FGitExtensions-Portable-3.00.00.4308.zip

spdr870 commented 6 years ago

@spdr870 I couldn't repro this on spdr870/feature/graph_spdr870 @ 3efe3db it seems you've fixed it there with LaneInfo changes.

This is indeed what the LaneInfo branch should fix. There is also a branch with only the LaneInfo change, without any other layout changes in the graph. I need some time to finish this code. It works, its stable, but the code is not cleaned yet.

@RussKie From what commit is this build?

RussKie commented 6 years ago

That's from v3 release branch

On Tue, Nov 27, 2018, 9:51 PM Henk Westhuis notifications@github.com wrote:

@spdr870 https://github.com/spdr870 I couldn't repro this on spdr870/feature/graph_spdr870 @ 3efe3db https://github.com/gitextensions/gitextensions/commit/3efe3dba325e6178b7c256fa4297b409e2670730 it seems you've fixed it there with LaneInfo changes.

This is indeed what the LaneInfo branch should fix. There is also a branch with only the LaneInfo change, without any other layout changes in the graph. I need some time to finish this code. It works, its stable, but the code is not cleaned yet.

@RussKie https://github.com/RussKie From what commit is this build?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gitextensions/gitextensions/issues/5817#issuecomment-442014811, or mute the thread https://github.com/notifications/unsubscribe-auth/AEMyXkcGzza2J6Kj24SqlMQSKTztFdGJks5uzRk_gaJpZM4Y1Ff0 .

mdonatas commented 6 years ago

@RussKie I can repro it in the portable build you gave.

gerhardol commented 6 years ago

I suggest we release 3.0 now and release 3..0.1 quite soon, with for instance lane info changes

RussKie commented 6 years ago

We're on the home run with the v3. I'd expect 3.00.01 to release within several weeks of the major release.