search

gitextensions / gitextensions

Git Extensions is a standalone UI tool for managing git repositories. It also integrates with Windows Explorer and Microsoft Visual Studio (2015/2017/2019).
https://gitextensions.github.io/
Other
7.66k stars 2.07k forks source link

[3.0] Hotkey CTRL+DOWN does not perform default pull button action anymore #5885

Open drauch opened 5 years ago

drauch commented 5 years ago

What is the current behavior?

In 2.x the CTRL+DOWN hotkey performed the default pull button action. In 3.0 the behavior changed, it always opens the fetch/pull dialog, regardless of what I choose as the default pull button action.

What is the expected behavior?

Is there a new hotkey? I can't find one. I want to do "fetch all" without any dialogs inbetween with a simple hotkey.

vbjay commented 5 years ago

image

vbjay commented 5 years ago

We have an issue template for a reason. 

<!--
IMPORTANT

Before creating an issue, be sure to search existing issues, both open AND closed,
to see whether someone else has already reported your issue.

Please also read CONTRIBUTING.md.
-->

**Do you want to request a *feature* or report a *bug*?**

**What is the current behavior?**

**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.**

**What is the expected behavior?**

**Environment you encounter the issue:**

<!--
Help->About Copy button or Help->Report an issue link will put this info in the clipboard.
-->
- GitExtensions version:
- GIT version: 
- OS version: 
- .NET version: 

**Did this work in previous version of GitExtensions (which)?**

<!-- Love gitextensions? Please consider supporting our collective:
👉  https://opencollective.com/gitextensions/donate -->
drauch commented 5 years ago

Quick fetch is not what I want. It does "fetch" and not "fetch all", regardless of what setting I set as the default.

Also, I used the issue template, just deleted what was irrelevant. If you need more information, please say so, I'm happy to provide it.

vbjay commented 5 years ago

Always include environment info. Help-> About will let you copy this from GE.

We have an issue template for a reason. It gives us what we need. We expect the issue template to be filled out.

vbjay commented 5 years ago

So add a script that does what you want and set the hotkey to the desired value.

On Tue, Dec 11, 2018, 10:07 AM drauch notifications@github.com wrote:

Quick fetch is not what I want. It does "fetch" and not "fetch all", regardless of what setting I set as the default.

Also, I used the issue template, just deleted what was irrelevant. If you need more information, please say so, I'm happy to provide it.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/gitextensions/gitextensions/issues/5885#issuecomment-446235258, or mute the thread https://github.com/notifications/unsubscribe-auth/ADdhsXfvAHCiSy8r5tOL6NqziUy2fnGoks5u38oogaJpZM4ZNeaV .

drauch commented 5 years ago

So add a script that does what you want and set the hotkey to the desired value.

How do you insert "perform default pull button action" into a script?

vbjay commented 5 years ago

You script the actual git command. If you want fetch all or even fetch all with submodules then Command git

fetch --all

Or Command sh

-c " git fetch --all && git submodule foreach --recursuve git fetch --all"
drauch commented 5 years ago

But I do not want to always use fetch all, just in some repositories. I want one hotkey for "default pull button action", just like in 2.x :-)

gerhardol commented 5 years ago

This seem to be hardcoded now, probably a consequence of the rewritten default handling

           this.pullToolStripMenuItem.ShortcutKeys = ((System.Windows.Forms.Keys)((System.Windows.Forms.Keys.Control | System.Windows.Forms.Keys.Down)));

But the workaround is not too difficult: Press return, the form is filled in correctly

drauch commented 5 years ago

The workaround is unpleasant, opening the dialog takes up to five seconds. I guess this is a performance problem...

...would be glad if the shortcut could be configured just like in the 2.x version 👍

gerhardol commented 5 years ago

...would be glad if the shortcut could be configured just like in the 2.x version

The shortcut was hardcoded in 2.x, just that the Form did not open

drauch commented 5 years ago

just that the Form did not open In that case, I'd love to have that again :)

vbjay commented 5 years ago

It takes roughly a second maybe less for the form to show. Record how long it really takes use https://www.screentogif.com/ trim the beginning before you pressed the keys. Drag created gif to a comment here.

gerhardol commented 5 years ago

There are over 20 hardcoded shortcuts that should be made configurable. The hardcoded shortcuts could conflict with language defaults.

In this case the changed functionality for the pull dialog (the "set next action as default") that likely is the reason.

vbjay commented 5 years ago

Yep. Wouldn't want a fetch and prune with a simple key press. Pretty sure that's why the shortcut shows the dialog.

drauch commented 5 years ago

@vbjay : I press the shortcut CTRL+DOWN immediately after opening the repository. That's when it takes so long. Is this scenario faster for you? I have made a screen recording with ScreenToGif but realized that I can't make it public for legal reasons. If you give me your e-mail address I can send it in private to you if you like.

RussKie commented 5 years ago

I press the shortcut CTRL+DOWN immediately after opening the repository. That's when it takes so long.

This is likely a dup of #5829 and related to #5884.

gerhardol commented 5 years ago

This is likely a dup of #5829 and related to #5884

2.x is not faster here but you you do not have to wait for the form to appear so you can start concentrate on something else directly

vbjay commented 5 years ago

I tend to wait for the form to be up and it is done doing its thing.

That's ok. I was mainly looking for timing. Does it only do it for your repo or every repo?

On Wed, Jan 2, 2019, 4:29 AM Gerhard Olsson notifications@github.com wrote:

This is likely a dup of #5829 https://github.com/gitextensions/gitextensions/issues/5829 and related to #5884 https://github.com/gitextensions/gitextensions/issues/5884

2.x is not faster here but you you do not have to wait for the form to appear so you can start concentrate on something else directly

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/gitextensions/gitextensions/issues/5885#issuecomment-450818154, or mute the thread https://github.com/notifications/unsubscribe-auth/ADdhsdlNgNGJ79DsFN-W4H8JgRM5k_6Gks5u_HwSgaJpZM4ZNeaV .