gitfredy / google-glog

Automatically exported from code.google.com/p/google-glog
Other
0 stars 0 forks source link

Can't build on VS2011 beta #117

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open and upgrade existing solution file with VS2011 beta
2. Build Solution

What is the expected output? What do you see instead?
1. Expect build success.
2. Compile error:
   1>ClCompile:
   1>  vlog_is_on.cc
   2>c:\program files (x86)\microsoft visual studio 11.0\vc\include  \vector(2912): error C2143: syntax error : missing ';' before '<'
   1>c:\program files (x86)\microsoft visual studio 11.0\vc\include\vector(2912): error C2143: syntax error : missing ';' before '<'
   ...

What version of the product are you using? On what operating system?
1. Windows 7, VS2011 Beta

Please provide any additional information below.
1. traced problem to following line in src\windows\port.h
   #define hash  hash_compare

2. Wrap the macro definition with version check will fix the problem
   #if _MSC_VER < 1700
   #define hash  hash_compare
   #endif

Original issue reported on code.google.com by xgz...@gmail.com on 10 Mar 2012 at 10:45

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
VS2011 Beta is now VS2012... and of course this is still broken.

Original comment by and...@spacemonkey.com on 2 Oct 2012 at 8:18

GoogleCodeExporter commented 9 years ago
Thanks for the fix

Original comment by kikijiki...@gmail.com on 13 Oct 2012 at 10:42

GoogleCodeExporter commented 9 years ago
Thanks for this fix.

Original comment by x.w...@nbsystems.tv on 2 Nov 2012 at 10:03

GoogleCodeExporter commented 9 years ago
Note: this is currently fixed in CVS, as of 10 Dec 2012. It reads

#if defined(_MSC_VER) && (_MSC_VER < 1700)
#define hash  hash_compare
#endif

It isn't in the official download tar package though.

Original comment by Massimo...@gmail.com on 10 Dec 2012 at 2:19