search

gitfrosh / lotr-api

This repository holds the code base of the API to rule them all, the Lord of the Rings api, which provides you with book, character, movie and quotes data.
https://the-one-api.dev
238 stars 66 forks source link

Fix Denethor II quote character attribution #107

Closed pandincus closed 10 months ago

pandincus commented 1 year ago

While playing around with the API, I noticed that I couldn't get any quotes back for Denethor II. (Denethor II is the character we know from the films and books)

Upon inspecting the DB, I see that all of Denethor II's quotes are actually attributed to Denethor I, which is incorrect. Therefore, I've updated the CSV.

Specifically, I've simply done a find-and-replace to replace 5cd99d4bde30eff6ebccfca1 (Denethor I) with 5cd99d4bde30eff6ebccfc9a (Denethor II).

MateuszKikmunter commented 1 year ago

Good catch, looks OK to me. :)