Add PWA support to the-one-api.dev

gitfrosh / lotr-api

This repository holds the code base of the API to rule them all, the Lord of the Rings api, which provides you with book, character, movie and quotes data.

https://the-one-api.dev

238 stars 66 forks source link

Add PWA support to the-one-api.dev #15

Closed gitfrosh closed 4 years ago

gitfrosh commented 4 years ago

The The one API documentation website (https://the-one-api.dev) is not yet PWA ready.

see https://web.dev/progressive-web-apps for more info
task would include adding a manifest, service worker and others

Any help is appreciated! :rocket:

vanshajtyagi commented 4 years ago

Hi, I would like to help but could please explain to me what all I have to do . Like You want to make a manifest file for the one api.dev? { "name": "The One API", "theme_color": "#2196f3", "background_color": "#2196f3", "display": "browser", "scope": "/", "start_url": "/https://the-one-api.dev/" } Like this you want !!

gitfrosh commented 4 years ago

There are some (more) requirements, that would mark the-one.api.dev as a PWA, one of them is adding a manifest. The Chrome extension Lighthouse (https://developers.google.com/web/ilt/pwa/lighthouse-pwa-analysis-tool) is a great tool to check if all requirements are fulfilled. If you feel confident, you may add a pull request to this issue. Thanks!

gabrielclaudino commented 4 years ago

Hello, I can help with this issue 😀