search

gitfx / ActionServerless

Use GitHub Actions to create a Serverless service.
https://gitfx.github.io/
Apache License 2.0
109 stars 6 forks source link

Add PHP support #3

Closed jbrooksuk closed 3 years ago

jbrooksuk commented 3 years ago

I feel like I've done something wrong here as this doesn't seem to work in my test repository, https://github.com/jbrooksuk/ActionServerlessPHP

But it's a start!

gingerhot commented 3 years ago

@jbrooksuk Thank you for contribution! I can see there're some problems:

  1. I updated workflow config, you need rebase the code
  2. You comment with a "#", it should be "//" indeed: https://github.com/gitx-io/ActionServerless/pull/3/commits/68a791d597de54b5a446d30e6f13191e2dbec325#diff-696942316c4943717efeb63704eb4f92be0cfa63754ea6f6aa62e186680e32cdR3
  3. all the result here is generated by the action workflow, it is not the ground truth for the test. That means you need not to create such a file. If the action works for the new language, there will be such a generated file after action complete. We just check the generated file manually at present
  4. I advise that you don't support dependency installation at present to realize a minimal support for PHP at first step:https://github.com/JamesForks/ActionServerless/blob/php-support/run_funcs.py#L44
  5. You forked the template repo to test, but the template is using released version v1. Your new code not be released yet. You should just check the action code, don't use the template to test.

Thanks again for your contribution!

jbrooksuk commented 3 years ago

Thanks @gingerhot! I have made the changes now.

jbrooksuk commented 3 years ago

It works! https://github.com/jbrooksuk/ActionServerlessPHP/blob/master/test_hello_world_php

gingerhot commented 3 years ago

Great! Would you please squash the commits as single commit? Then I will merge this pr. Thank you again.

jbrooksuk commented 3 years ago

Done!