gitgift / minimalist

Automatically exported from code.google.com/p/minimalist
0 stars 0 forks source link

Gmail > Main > Row > Highlight unread and Highlight starred don't work #119

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
(tested with osx lion and ubuntu, last chrome version)

Original issue reported on code.google.com by im.dri...@gmail.com on 3 Dec 2011 at 11:55

GoogleCodeExporter commented 8 years ago
This information is actually important please fill it out:

Minimalist version   -
Relevant core module -
Chrome version       -
Operating System     -
Language             -
Google Apps user?    -
Other extensions     -

And I know you're Chrome version supposed to be the latest but the reason I put 
it there is to see if Chrome isn't updating for you. Leave a version number.

Original comment by anst...@gmail.com on 3 Dec 2011 at 3:41

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
chrome 15.0.874.121 with other extensions disabled, without active flags
tell me if you need other info

Original comment by im.dri...@gmail.com on 3 Dec 2011 at 4:34

GoogleCodeExporter commented 8 years ago
Do highlight checked or highlight selected work?

Do you have the new Google Bar?

Are you getting any runtime errors? (Tools > JavaScript Console > Errors)

Original comment by anst...@gmail.com on 3 Dec 2011 at 4:45

GoogleCodeExporter commented 8 years ago
i use with no errors the highlight selected item feature

i haven't the new google bar (google.it)

i get these errors: 
Unsafe JavaScript attempt to access frame with URL 
https://mail.google.com/mail/?ui=2&shva=1#inbox from frame with URL 
https://plus.google.com/_/apps-static/_/js/nw/nw_i/rt=h/ver=VsJeF36_ow8.it./sv=1
/am=!EcKgcW1OAprNd911VivPfXEZvA3Sj3Fvkf0/d=1/. Domains, protocols and ports 
must match.
https://mail.google.com/mail/channel/bind?VER=8&at=AF6bupP2kg_A6dZ8ASqH8x1enijdb
9_17w&ui=2&it=8113444&SID=F0B0B75BE6074F47&RID=49784&AID=177&zx=s05he7jkgtba&t=3
Failed to load resource: the server responded with a status of 400 (Unknown SID)

Original comment by im.dri...@gmail.com on 3 Dec 2011 at 4:55

GoogleCodeExporter commented 8 years ago
That error is thrown by Gmail, not by Minimalist.

Right click the star icon on a starred item. Select "Inspect Element". A panel 
of code should come up with a line highlighted that starts with "<span".

What does your title attribute say? Mine says "title="Starred"

Original comment by anst...@gmail.com on 3 Dec 2011 at 5:00

GoogleCodeExporter commented 8 years ago
should i check it with highlight starred option turned on or turned off?

Original comment by im.dri...@gmail.com on 3 Dec 2011 at 5:01

GoogleCodeExporter commented 8 years ago
It doesn't matter. Minimalist doesn't modify that value.

Original comment by anst...@gmail.com on 3 Dec 2011 at 5:03

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
i've changed gmail language to english, so it'll be simpler (:D)
the attribute title is "Starred"

Original comment by im.dri...@gmail.com on 3 Dec 2011 at 5:09

GoogleCodeExporter commented 8 years ago
I think I've found a non-language specific way to determine if an item is 
starred. I'm going to update today and it should fix your issue (you won't have 
to use Gmail in English)

Original comment by anst...@gmail.com on 3 Dec 2011 at 5:11

GoogleCodeExporter commented 8 years ago
great. i noticed also another problem with languages. i'll start a new issue 
explaining it better

Original comment by im.dri...@gmail.com on 3 Dec 2011 at 5:16

Attachments:

GoogleCodeExporter commented 8 years ago
user error. in both images the Hide Google Links option is enabled
in the first image the language is set to english, there is the new google bar 
and the minimalist options doesn't modify it. 
in the second image there is the old google bar, modified by the enabled option

Original comment by im.dri...@gmail.com on 3 Dec 2011 at 5:28

GoogleCodeExporter commented 8 years ago
Ah, yes the currently published version is not compatible with the new Google 
Bar. I have an update that is compatible and almost ready to go. I need to do a 
bit of testing and I'll push it in the next hour or so.

Original comment by anst...@gmail.com on 3 Dec 2011 at 5:31

GoogleCodeExporter commented 8 years ago
awesome. for me you can take your time... i'll not receive any changes soon 
(sob), but it's nice to know that there is someone like you

Original comment by im.dri...@gmail.com on 3 Dec 2011 at 5:37

GoogleCodeExporter commented 8 years ago
Fixed in 0.5.17

Original comment by anst...@gmail.com on 3 Dec 2011 at 9:10