git-compat-util: move `convert_slashes` from compat/mingw.h and rename it

[mohit-marathe]

Hi all,

This series aims to complete a #leftoverbits: https://lore.kernel.org/ git/xmqqzfw43xad.fsf@gitster.g/ by moving convert_slashes() to git-compat-util.h and renaming it to change_path_separators().

I appreciate your review and feedback on this patch series.

Best regards, Mohit Marathe

cc: Josh Steadmon steadmon@google.com

[mohit-marathe]

/preview

[gitgitgadget[bot]]

Preview email sent as pull.1699.git.1710764905.gitgitgadget@gmail.com

[mohit-marathe]

/submit

[gitgitgadget[bot]]

Submitted as pull.1699.git.1710766062.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1699/mohit-marathe/convert-slashes-v1

To fetch this version to local tag pr-1699/mohit-marathe/convert-slashes-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1699/mohit-marathe/convert-slashes-v1

[mohit-marathe]

Hi @dscho! I made this patch after seeing your comment here: https://lore.kernel.org/git/0fb4e912-b25e-0240-c49f-aac5cbc3ef9e@gmx.de/ I have to write a proper commit description but I don't understand why do we have to move convert_slashes() to git-compat-util.h. Sorry, I should've asked this earlier, before submitting the patch.

[dscho]

why do we have to move convert_slashes() to git-compat-util.h.

It is only available on Windows so far, thanks to being defined in compat/mingw.h. In https://lore.kernel.org/git/0fb4e912-b25e-0240-c49f-aac5cbc3ef9e@gmx.de/ we were discussing a patch for code running on all platforms, not just Windows.

[gitgitgadget[bot]]

User Josh Steadmon <steadmon@google.com> has been added to the cc: list.