Closed dscho closed 2 months ago
/submit
Submitted as pull.1795.git.1726687276169.gitgitgadget@gmail.com
To fetch this version into FETCH_HEAD
:
git fetch https://github.com/gitgitgadget/git/ pr-1795/dscho/clar-unit-tests+cmake-v1
To fetch this version to local tag pr-1795/dscho/clar-unit-tests+cmake-v1
:
git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1795/dscho/clar-unit-tests+cmake-v1
On the Git mailing list, Junio C Hamano wrote (reply to this):
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> In c3de556a841f (Makefile: rename clar-related variables to avoid
> confusion, 2024-09-10) some `Makefile` variables were renamed that were
> partially used by the CMake definition. Adapt the latter to the new lay
> of the land.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> cmake: rename clar-related variables to avoid confusion
>
> This is an add-on for ps/clar-unit-tests to let it build with CMake and
> Visual C.
Thanks.
The base topic is expected to graduate to 'master' in a day or two,
so this is a very timely and welcome update.
This patch series was integrated into seen via https://github.com/git/git/commit/35b7d19b5f45aa4ad8f873af66f3fac56e5cfc56.
This patch series was integrated into seen via https://github.com/git/git/commit/2c4e8a806a9814c06d2c76ccd6efe08a95161e7d.
This patch series was integrated into next via https://github.com/git/git/commit/d892dcdcdd656c16370b586a56702de7f4047d07.
This patch series was integrated into seen via https://github.com/git/git/commit/a452b348de9c49f924b1774fc1da39e034febd67.
This patch series was integrated into seen via https://github.com/git/git/commit/9a970bd1e03cae2318d2c0182f4a1ba71cbccf51.
On the Git mailing list, Patrick Steinhardt wrote (reply to this):
On Wed, Sep 18, 2024 at 07:21:16PM +0000, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> In c3de556a841f (Makefile: rename clar-related variables to avoid
> confusion, 2024-09-10) some `Makefile` variables were renamed that were
> partially used by the CMake definition. Adapt the latter to the new lay
> of the land.
Ah, thanks for the fixup! I really hope that I can (soonish) make the
case for CMake being part of our officially supported build systems that
is also exercised as part of our CI.
Patrick
User Patrick Steinhardt <ps@pks.im>
has been added to the cc: list.
This patch series was integrated into seen via https://github.com/git/git/commit/1050870ecc02b4f155b6c2ba91d1726fb293ce71.
This patch series was integrated into seen via https://github.com/git/git/commit/cbb5b53a9c0e6bbe6f8df2dd371735ecbc710fe7.
This patch series was integrated into master via https://github.com/git/git/commit/cbb5b53a9c0e6bbe6f8df2dd371735ecbc710fe7.
This patch series was integrated into next via https://github.com/git/git/commit/cbb5b53a9c0e6bbe6f8df2dd371735ecbc710fe7.
Closed via cbb5b53a9c0e6bbe6f8df2dd371735ecbc710fe7.
This is an add-on for
ps/clar-unit-tests
to let it build with CMake and Visual C.cc: Patrick Steinhardt ps@pks.im