read-cache: two small leak fixes

[derrickstolee]

This v2 removes the duplicate patch and updates the commit message.

Thanks, -Stolee

cc: gitster@pobox.com cc: peff@peff.net cc: ps@pks.im

[derrickstolee]

/submit

[gitgitgadget[bot]]

Submitted as pull.1801.git.1727696424.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1801/derrickstolee/leaks-v1

To fetch this version to local tag pr-1801/derrickstolee/leaks-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1801/derrickstolee/leaks-v1

[derrickstolee]

/submit

[gitgitgadget[bot]]

Submitted as pull.1801.v2.git.1727804265033.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1801/derrickstolee/leaks-v2

To fetch this version to local tag pr-1801/derrickstolee/leaks-v2:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1801/derrickstolee/leaks-v2

[gitgitgadget[bot]]

This patch series was integrated into seen via https://github.com/git/git/commit/38d328abdb7c0d43e4807ea546c0982be37baa4d.

[gitgitgadget[bot]]

On the Git mailing list, Patrick Steinhardt wrote (reply to this):

On Tue, Oct 01, 2024 at 05:37:44PM +0000, Derrick Stolee via GitGitGadget wrote:
> From: Derrick Stolee <stolee@gmail.com>
> 
> In load_cache_entries_threaded(), each thread allocates its own memory
> pool. This pool needs to be cleaned up while closing the threads down,
> or it will be leaked.
> 
> This ce_mem_pool pointer could theoretically be converted to an inline
> copy of the struct, but the use of a pointer helps with existing lazy-
> initialization logic. Adjusting that behavior only to avoid this pointer
> would be a much bigger change.

Thanks, this looks good to me.

Patrick

[gitgitgadget[bot]]

This branch is now known as ds/read-cache-mempool-leakfix.

[gitgitgadget[bot]]

This patch series was integrated into seen via https://github.com/git/git/commit/4887e214052e72a3c899b64f567a6407c63c7989.

[gitgitgadget[bot]]

This patch series was integrated into next via https://github.com/git/git/commit/c0eac890ac89919a95485bee9523f2d16276993b.

[gitgitgadget[bot]]

There was a status update in the "New Topics" section about the branch ds/read-cache-mempool-leakfix on the Git mailing list:

Leakfix.

Will merge to 'master'.
source: <pull.1801.v2.git.1727804265033.gitgitgadget@gmail.com>

[gitgitgadget[bot]]

This patch series was integrated into seen via https://github.com/git/git/commit/b4efdfe16555f989eb977f77142a0c60571be34b.

[gitgitgadget[bot]]

This patch series was integrated into master via https://github.com/git/git/commit/b4efdfe16555f989eb977f77142a0c60571be34b.

[gitgitgadget[bot]]

This patch series was integrated into next via https://github.com/git/git/commit/b4efdfe16555f989eb977f77142a0c60571be34b.

[gitgitgadget[bot]]

Closed via b4efdfe16555f989eb977f77142a0c60571be34b.