search

github-af / SmartPGP

SmartPGP is a JavaCard implementation of the OpenPGP card specifications
GNU General Public License v2.0
229 stars 48 forks source link

Use the right register() method #20

Closed martinpaljak closed 4 years ago

martinpaljak commented 4 years ago

https://docs.oracle.com/javacard/3.0.5/api/javacard/framework/Applet.html#register(byte[],%20short,%20byte)

Otherwise it is not possible to assign the instance AID during installation.

af-anssi commented 4 years ago

Could you confirm that commit 89608a2 has fixed this issue and close this issue accordingly?

martinpaljak commented 4 years ago

Yep!

bmunger commented 4 years ago

Is there a reason why this, and some other commits were only done on the 3.0.1 branch and not in 3.0.4 or master?

af-anssi commented 4 years ago

Actually, the javacard-3.0.4 branch is systematically rebased on the javacard-3.0.1 branch, so it does include the commit (cf commit history where the commit 89608a2 is the first commit on Jan 13, 2020).

af-anssi commented 4 years ago

@martinpaljak I will close the issue if it is OK for you.

martinpaljak commented 4 years ago

Good for me, was reporting it on behalf of a user struggling to install it with GPPro.

af-anssi commented 4 years ago

Thank you for reporting this issue on behalf of that user. It actually simplifies the deployment of the applet, especially at medium/large scale.