github-amanda / pe

0 stars 0 forks source link

Inconsistency found in case-sensitivities in "find" and "add" #7

Open github-amanda opened 3 years ago

github-amanda commented 3 years ago

I noticed that for "add" function, the names are case-sensitive (i.e. "john" and "John" are identified as two different individuals). However, for "find" function, the names searched are case-insensitive (i.e. searching for "john" gives "John" as well), which suggests that "john" and "John" are the same individuals. In my opinion, since "john" and "John" are two different individuals as defined in "add", it would make more sense if the names in "find" are case-sensitive as well, just to be consistent with the idea of "john" and "John" being 2 different individuals! Either that, or you can modify "add" such that the names are case-insensitive, which would make more sense to a user :)

image.png

image.png

nus-pe-bot commented 3 years ago

Team's Response

Hi thank you for your suggestion. In regards to case-sensitivity we have pointed out in the UG as attached below.

image.png

In regards to the find being case-insensitive, it is an intended feature as we wanted to ensure that if a user added John Doe and john, the user can just type a john as the keyword to get both person.

As we had clearly description this case sensitivity in the UG as well, we felt that this is not an issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that this was stated in your User Guide. However, as a user who read your user guide to get a brief idea of how the functions work (and I believe most users will not read your user guide so in-depth to be able to remember which functions are case-sensitive and which are not), it is not as intuitive since names can be differentiated using lower/upper case, but the "find" function do not differentiate them.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]