github-community-projects / graphql-client

A Ruby library for declaring, composing and executing GraphQL queries
MIT License
45 stars 219 forks source link

Update gem homepage #3

Closed hogelog closed 10 months ago

hogelog commented 10 months ago

I noticed that https://rubygems.org/gems/graphql-client 0.19.0 has been released but wondered why there is no 0.19.0 code on https://github.com/github/graphql-client.

Has the graphql-client repository moved here? If so, I thought the gem's homepage attribute should be updated.

jgarber623 commented 10 months ago

Landed here with the same question.

As noted by @hogelog, RubyGems.org links to github/graphql-client via the published gem's metadata. Confused by that, I started digging around and found @rmosolgo had pushed the latest v0.19.0. That led me to rmosolgo/graphql-client which does have a v0.19.0 tag but is also a fork of this project (github-community-projects/graphql-client).

rmosolgo/graphql-client and github-community-projects/graphql-client appear to be at parity at the moment, but between the three repositories, it's entirely unclear which is currently the official source for the published gem.

A proposal:

  1. Pick an official source repository (Maybe it's this one? I have no opinion here!)
  2. Update the published gem's metadata to includes links to that repository
  3. Update the other repositories (in the "About" section in the sidebar, maybe?) directing folks to the official source repository
  4. Update the README in github/graphql-client to link to the new official source repository (wherever it is) and archive that repository (assuming github/graphql-client is no longer maintained)

Maybe these steps are in the works? Maybe this PR makes them (mostly) unnecessary? Either way, I wanted to share my experience and confusion. Thanks for reading!

rmosolgo commented 10 months ago

Hey, thanks for taking a look @hogelog and @jgarber623. It's a bit hard to get a read on what's going on inside GitHub right now, but my understanding is:

Sorry for the confusion! I wanted to finally get this gem fixed for graphql-ruby 2.1.0 but maybe I shouldve taken it a bit slower 😅

rmosolgo commented 10 months ago

I just went to double-check about tags; it looks like there's a tag here: https://github.com/github-community-projects/graphql-client/releases/tag/v0.19.0 But not one on rmosolgo/graphql-client (https://github.com/rmosolgo/graphql-client/tags), so I think we're alright there :+1:

jgarber623 commented 10 months ago

@rmosolgo Thanks for the updates and clarifications!

Tangential to this PR:

This may or may not suit this project's needs (or your personal preferences), but have you considered setting up GitHub Actions and RubyGem's Trusted Publishing?

I've configured several of my gem to publish via GitHub Actions and with Trusted Publishing whenever I create a new GitHub Release (either via the web UI or with gh release create v0.1.0 --generate-notes).

If that sounds interesting, I could PR a thing. If not, no worries! 😄

rmosolgo commented 10 months ago

I'm definitely interested -- I went looking at that right after reading your comment. But I haven't set it up before. I'd love to see a PR if you're game to give it a try!

hogelog commented 10 months ago

Thanks for the clear explanation and merge! I also appreciate the ongoing development 😄