github-community-projects / private-mirrors

A GitHub App that allows you to contribute upstream using private mirrors of public projects

MIT License

119 stars 12 forks source link

feat: add stricter eslint rules for typescript #163

Closed ajhenry closed 2 months ago

ajhenry commented 2 months ago

Pull Request

Proposed Changes

While we were pairing on https://github.com/github-community-projects/internal-contribution-forks/pull/162, we found that we didn't add an await keyword to the function running the auth check. To prevent this from happening in the future, I added stricter eslint rules for typescript

This also fixes all the problems that arise from the addition of these rules. In general, we're looking pretty good 🥨

Readiness Checklist

Author/Contributor

[ ] If documentation is needed for this change, has that been included in this pull request
[x] run npm run lint and fix any linting issues that have been introduced
[x] run npm run test and run tests
[ ] If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

[x] Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

ajhenry commented 2 months ago

@zkoppert luckily next comes with eslint support 😄