[x] add .dockerignore so we don't copy node_modules from local to container via Dockerfile
we use a multi-stage build to install and use node_modules in the container
[x] change Dockerfile from --production to --omit=dev
[x] update docker-compose.yml
[x] remove version key and value (it's deprecated)
[x] change volume mounting so it doesn't obliterate node_modules and make packages unreachable
[x] remove unecessary key/values
Test Dockefile still works locally
docker build -t icf
docker run --it --rm --env_file .env -p 3000:3000 --name icf icf:latest
# go to http://localhost:3000
Test with docker-compose locally
docker-compose up -d
# go to http://localhost:3000
Readiness Checklist
Author/Contributor
[ ] If documentation is needed for this change, has that been included in this pull request
[x] run npm run lint and fix any linting issues that have been introduced
[x] run npm run test and run tests
[ ] If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz
Reviewer
[x] Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking
Pull Request
Proposed Changes
--production
to--omit=dev
Test Dockefile still works locally
Test with docker-compose locally
Readiness Checklist
Author/Contributor
npm run lint
and fix any linting issues that have been introducednpm run test
and run tests@jeffrey-luszcz
Reviewer
bug
,documentation
,enhancement
,infrastructure
,maintenance
, orbreaking