zkoppert commented 2 months ago

Pull Request

fixes #136

Proposed Changes

Updates the 'Edit mirror' dialog to display the current mirror name instead of the placeholder text 'repository-name'.

Changes the initial state of newMirrorName to use the mirrorName prop, ensuring the current mirror name is displayed when the dialog opens.
Updates the placeholder in the TextInput component to display the current mirror name, enhancing user experience by showing relevant information.
Adjusts the logic for resetting newMirrorName upon dialog actions (cancel, confirm, close) to revert to the current mirror name instead of the placeholder, maintaining consistency with the initial state change.

Readiness Checklist

Author/Contributor

[ ] If documentation is needed for this change, has that been included in this pull request
[x] run npm run lint and fix any linting issues that have been introduced
[x] run npm run test and run tests
[ ] If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

[x] Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

zkoppert commented 2 months ago

I believe we can but wanted to check: Can we safely assume that the mirrorName is never empty? Otherwise, this would result in the placeholder being blank.

zkoppert commented 2 months ago

Anyone have local dev setup working so they could check this looks correct in the running app? Otherwise I can work to get that setup going this afternoon.