github-community-projects / private-mirrors

A GitHub App that allows you to contribute upstream using private mirrors of public projects

MIT License

119 stars 12 forks source link

fix: add catch handling for already exists #193

Closed sutterj closed 2 months ago

sutterj commented 2 months ago

Pull Request

Proposed Changes

Fixes an issue caused by removing the try/catch around the exists call

Readiness Checklist

Author/Contributor

[ ] If documentation is needed for this change, has that been included in this pull request
[X] run npm run lint and fix any linting issues that have been introduced
[X] run npm run test and run tests
[ ] If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

[X] Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

sutterj commented 2 months ago

The alternative to this is letting removing the exists check altogether and letting the error be thrown when the repo fails to create, but doing this exists call first saves a few api calls.