Closed sinsukehlab closed 1 year ago
I haven't generated a repository from this template. The Start course should be changed to generate a repository in the organization @Exp-Intro-to-GitHub-Flow-Cohort-1 or something.
@mockra @ericdrosado Please review this PR. Any comments or suggestions are welcome.
Hi @mockra, thank you for your comment. I would really appreciate it if you could let me know the details about the classroom assignment flow. Is it the Start course button or the welcome step itself that breaks the classroom assignment flow? How do you generate for learners a new repository in the organization @Exp-Intro-to-GitHub-Flow-Cohort-1 from this repository?
Due to how we use the template, we're not able to leverage the flows in the
Welcome
step. It breaks the classroom assignment flow we use on the experience back-end. That's part of why we start users off on theCreate a Branch
section.If you're okay removing those changes from this pull request, I'd be happy to merge in your other improvements. 🙇🏻♂️
Hey @sinsukehlab, this repository is intended to be used for a GitHub Classroom assignment that can be accessed through this page.
The key piece that we can't support at the moment is the Start course button
. We're using a different flow than the Skills templates since it's the Classroom assignment that creates the repository for the student. Student will have already gone through a "welcome" flow before seeing the repository.
I have tried the assignment. I will remove the Start course button, which is not compatible with the Classroom assignment flow. The rest of the welcome step should be visible, for the page you provided doesn't have the contents of the welcome step. Now the remaining point of concern is the trigger of the Step 0 workflow. The step 0 workflow will update README.md and -step.txt to Step 1 when the initial commit is pushed. There is a possibility that a generated assignment repository will be already in Step 1 when students wait too long before seeing the repository, for they have to click on the link to see the repository.
This reverts commit 05e3146. The Start course button needs more updates for Global Campus.
Summary
Step 0 is invisible now.
Changes
Task list