github-education-resources / classroom-assistant

Clone student repositories in bulk
https://classroom.github.com/assistant
MIT License
116 stars 39 forks source link

Does not honor system setting core.autocrlf on windows #215

Open ccoenen opened 3 years ago

ccoenen commented 3 years ago

The Situation

I am using classroom assistant on windows, and Git defaults to changing around white space from \n to \r\n - which I think is a bad idea but that part is not your fault.

I set my git up in a way to never change any files on its own via git config --system core.autocrlf=false. This way I'm getting exactly the same file contents across all systems.

The Problem

When cloning a bunch of repositories through the classroom assistant, this setting is not being used, This has two disadvantages:

Basically, right after cloning, my IDE looks like this: grafik

The two repos that are not marked as changed (do not have the ember dot) are two that I cloned manually to verify that these are not identical.

What I would like instead

I would love it if classroom would either use the system's git settings (especially autocrlf). Or, if this is not possible, that there's a easily discoverable way to change github classroom's settings. I don't care if this is a GUI way to change it, or if I need to edit a config file or something like that. I just need to be able to find the correct way of configuring next time.

ccoenen commented 3 years ago

the setting is in effect for both --system and --global: grafik