github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.35k stars 568 forks source link

Speed bumps with the setup process #1837

Open c4lliope opened 5 years ago

c4lliope commented 5 years ago

Describe the bug Running the script to set the project up on my macintosh computer, I hit a number of errors.

I was hoping to start in on #1802, but the script/setup process has ended up overwhelming the work day.

Here is what I am working with so far:

  1. Add to Brewfile:
brew "rbenv"
brew "nodenv"
  1. In fish shell, add to ~/.config/fish/config.fish:
status --is-interactive; and . (rbenv init -|psub)
status --is-interactive; and . (nodenv init -|psub)
  1. Elasticsearch memory constraints: https://github.com/docker-library/elasticsearch/issues/111
docker-machine ssh
> sudo sysctl -w vm.max_map_count=262144
  1. Dependencies reversed in script/bootstrap:
  brew bootstrap-rbenv-ruby
  brew bootstrap-nodenv-node

work more predictably after the brew bundle check block, not before.


If I get this up and running tomorrow, I'll work to open a pull request with these changes.

Thanks!

BenEmdon commented 5 years ago

The script/setup isn't in the best shape 😕 Theres room for a ton of improvement! Any contributions are welcome 🙌

To ensure your PR's merge ASAP, keep them as small as possible so we can review them incrementally. Theres a sizeable PR backlog rn and it's easier for us to merge any low hanging fruit.

c4lliope commented 5 years ago

Another hiccup will pop up when you use the docker-machine VirtualBox driver. You need to forward ports from the VM to your localhost machine, with something like:


VBoxManage modifyvm "vbox" --natpf1 "tcp-port9227,tcp,,9227,,9227";
VBoxManage modifyvm "vbox" --natpf1 "udp-port9227,udp,,9227,,9227";

VBoxManage modifyvm "vbox" --natpf1 "tcp-port9337,tcp,,9337,,9337";
VBoxManage modifyvm "vbox" --natpf1 "udp-port9337,udp,,9337,,9337";

VBoxManage modifyvm "vbox" --natpf1 "tcp-port22322,tcp,,22322,,22322";
VBoxManage modifyvm "vbox" --natpf1 "udp-port22322,udp,,22322,,22322";

VBoxManage modifyvm "vbox" --natpf1 "tcp-port2345,tcp,,2345,,2345";
VBoxManage modifyvm "vbox" --natpf1 "udp-port2345,udp,,2345,,2345";

VBoxManage modifyvm "vbox" --natpf1 "tcp-port9736,tcp,,9736,,9736";
VBoxManage modifyvm "vbox" --natpf1 "udp-port9736,udp,,9736,,9736";
c4lliope commented 5 years ago

@BenEmdon thanks! I'll keep that in mind. Maybe this issue can serve more as documentation than a merge-able commit, because I'm new to the GitHub "one script to rule them all" policy.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.