search

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.35k stars 569 forks source link

SignalException every time a PR is deployed #1887

Closed EricPickup closed 5 years ago

EricPickup commented 5 years ago

I've noticed on Haystack that we get 4 SIGTERM/SignalException errors every time we deploy a PR to production.

@tarebyte pointed out that 4 is also the number of dynos we're running.

Example:

/app/vendor/bundle/ruby/2.4.0/gems/puma-3.10.0/lib/puma/cluster.rb:381:in `block in setup_signals'
/app/vendor/bundle/ruby/2.4.0/gems/puma-3.10.0/lib/puma/cluster.rb:475:in `select'
/app/vendor/bundle/ruby/2.4.0/gems/puma-3.10.0/lib/puma/cluster.rb:475:in `run'
/app/vendor/bundle/ruby/2.4.0/gems/puma-3.10.0/lib/puma/launcher.rb:183:in `run'
/app/vendor/bundle/ruby/2.4.0/gems/puma-3.10.0/lib/puma/cli.rb:77:in `run'
/app/vendor/bundle/ruby/2.4.0/gems/puma-3.10.0/bin/puma:10:in `<top (required)>'
./bin/puma:17:in `load'
./bin/puma:17:in `<main>'

(https://haystack.githubapp.com/classroom/needles/IWuUfmHU5nB5bFmPMxDXcw)

image

BenEmdon commented 5 years ago

Is this issue proposing that we shouldn't report these specific errors?

EricPickup commented 5 years ago

@BenEmdon not necessarily, just opening it to eventually investigate the cause. Not sure if it's something to be concerned about

BenEmdon commented 5 years ago

This SIGTERM is an expected puma related signal which we expect on every deploy on heroku.

In my opinion, exceptions in haystack should be exceptional and receiving signals like SIGTERM are exceptional.

I realize that these could add to the noise, but removing it might take away value.

Conclusively, I think we could close this issue. If you disagree please reopen this issue.