search

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.35k stars 569 forks source link

SignalException raised on deployment #2185

Closed shaunakpp closed 5 years ago

shaunakpp commented 5 years ago

Whenever we deploy, our exception tracker gets noisy with the SignalExcpetion due to Puma receiving a SIGTERM. This is an expected behavior and should not be raised. It can be fixed adding raise_exception_on_sigterm(false) to our Puma config.

More information here:

https://github.com/puma/puma/pull/1690

Needle: https://haystack.githubapp.com/classroom/needles/zMtX4AGAjJVlre9rBQyzOA Rollup: https://haystack.githubapp.com/classroom/rollups/194428943c1becce2f5745f9bb3a5ed8

SignalException
SIGTERM
attribute value
argv ./bin/puma -C config/puma.rb
class_name SignalException
halting true
ruby ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux]
Backtrace 
/app/vendor/bundle/ruby/2.4.0/gems/puma-4.0.1/lib/puma/cluster.rb:419:in `block in setup_signals'
/app/vendor/bundle/ruby/2.4.0/gems/puma-4.0.1/lib/puma/cluster.rb:514:in `select'
/app/vendor/bundle/ruby/2.4.0/gems/puma-4.0.1/lib/puma/cluster.rb:514:in `run'
/app/vendor/bundle/ruby/2.4.0/gems/puma-4.0.1/lib/puma/launcher.rb:186:in `run'
/app/vendor/bundle/ruby/2.4.0/gems/puma-4.0.1/lib/puma/cli.rb:80:in `run'
/app/vendor/bundle/ruby/2.4.0/gems/puma-4.0.1/bin/puma:10:in `<top (required)>'
./bin/puma:17:in `load'
./bin/puma:17:in `<main>'

Brought to you by Haystack's ! hotkey. Try it on a needle or rollup today!

shaunakpp commented 5 years ago

solved by #2186