search

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.35k stars 569 forks source link

Remove Beta badge on template repositories #2346

Open EricPickup opened 5 years ago

EricPickup commented 5 years ago

I mentioned this in Slack during my last week. We should remove the Beta badge on the template repos feature since it has been working properly for over a month and performing all of the expected behavior.

We could also replace it with a NEW! badge instead of completely removing it.

The new school year is starting and I wouldn't want teachers to be afraid of using this amazing new feature during the peak of Classroom usage!

image

stephaniegiang commented 5 years ago

@femmebot would replacing the "Beta" with "New" text be enough? Or should there also be a color change?

femmebot commented 5 years ago

Before we remove the label, is there a reason why we only display the radio buttons after they enter the name of the repo? And why does it automatically pre-select the template repo option (even if the repo is not a template repo)?

stephaniegiang commented 5 years ago

@femmebot that is a really good question. I don't know why. We could change it so that it is there whether they have entered the name of the repo.

femmebot commented 5 years ago

Had a thought shown in this quick sketch…

It seems like we need them to identify whether the source repo is a template repo or not. What if we had a combo option-selection and search field:

Screen Shot 2019-09-06 at 2 24 38 PM

This allows us to check whether the repo they entered is a template repo…

Screen Shot 2019-09-06 at 2 16 48 PM

If it isn't, then we can display the appropriate warning (I'm not sure if we do actually try to convert it into a template repo…I thought I read chatter about that elsewhere)

Screen Shot 2019-09-06 at 2 17 00 PM
stephaniegiang commented 5 years ago

Oh I love this ❤️

spinecone commented 5 years ago

It looks like we're not actually attempting to convert non-template repos into templates: Screen Shot 2019-09-09 at 3 22 47 PM

Something I was unsure about was why we allow users to choose a template repo, but not use the template repo option. Is there a valid/common use case for that? If not we could just detect whether or not the repo is a template and choose for them.

femmebot commented 5 years ago

Since template repos were only introduced recently, chances are, their starter repos are not template repos (it's something they need to enable in the UI so it's another step for them) which is why the other, older option is still being provided. In the example you cited, what we could do is show a message that says something like "This is a template repository. We recommend using the template repository import method instead." In part, what we want to do is, rather than do things for them, we want to train them to help shape the behaviors we want.

--

addendum: found this issue Add ability to make a repo into a template repo through Classroom https://github.com/education/classroom/issues/2032

femmebot commented 5 years ago

Related: https://github.com/education/classroom/issues/2375