search

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.35k stars 568 forks source link

Add ability to create assignment or archive class from org#index page #2391

Closed JessRudder closed 5 years ago

JessRudder commented 5 years ago

Part of #602 Note - this includes an update to the octicon gem

Adds a dropdown menu to the upper right corner of each classroom card on the classroom index page.

That menu currently contains two options:

Create lesson - Takes the user to the lesson creation flow for that classroom

archive-create-new

Archive classroom - Allows a user to archive the classroom from this view (Note: This becomes Unarchive classroom if the classroom is archived). It preserves all filters that were already in place for the view (e.g. if you are only viewing active, when you archive a classroom, it will be removed from view).

archive-from-index

stephaniegiang commented 5 years ago

This looks great! I just have one question. On an archived classroom, if I click the menu I still get Create assignment as one. Should teachers still be able to add assignments to archived classes?

femmebot commented 5 years ago

I wasn't sure if that was scoped for archiving (I'd seen earlier discussions about keeping it simply as a way to hide non-active classrooms). If we're disabling any activity for archived classrooms then we should disable that option.

stephaniegiang commented 5 years ago

That makes sense. This can be a later discussion then 😄

JessRudder commented 5 years ago

@stephaniegiang great catch! I think currently archiving a classroom only stops people from accepting invites. I guess the thinking was that if a teacher has archived a classroom, they won't be making new lessons for it anyway.

@femmebot should we explicitly prevent creation of more assignments for archived classrooms? It should be a simple relatively simple change to make.

femmebot commented 5 years ago

@femmebot should we explicitly prevent creation of more assignments for archived classrooms? It should be a simple relatively simple change to make.

Yes, let's disable the ability to create new assignments on an archived classroom if it's relatively simple. I think it's the expected behavior.