github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 564 forks source link

Investigate why failed Edge/IE imports weren't logged #2434

Open d12 opened 4 years ago

d12 commented 4 years ago

In https://github.com/education/classroom/issues/2431, there were a number of failed imports but we had no metrics indicate this. In the future, issues like this should surface in our dashboards so we can identify issues earlier, and accurately quantify impact.

cc @spinecone

spinecone commented 4 years ago

I'm not yet certain if this was a case of imports failing or not starting at all. We can add more metrics for API requests that explicitly fail (including browser info), but I'm not sure what would the best way to log imports that never start.

spinecone commented 4 years ago

Talked with @JessRudder today about possible ways to prevent problems like this from coming up again: