github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 564 forks source link

Fix search and filter form on Firefox #2435

Closed JessRudder closed 4 years ago

JessRudder commented 4 years ago

**** NOTES **** This is adding back some of the work that was reverted in #2432

This includes only the changes related to getting the form to work on Firefox. It does not include the details-menu js change which is what appears to have caused the break.

I've tested form functionality and assignment import functionality on Chrome, Safari, Firefox and Edge with these changes and it is working on all of them. **** NOTES ****

Previously the search/filter form on the /classrooms page was not working in Firefox. It was submitting twice (the first time correctly as an async request and the second time as a full page load).

This updates the dispatchEvent for the form submission so it includes cancelable: true which prevents the double submission. It also gets the debounce working correctly so we aren't spamming the search end point.