Add roster identifier to assignment repos endpoint - Githubissues

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.

https://classroom.github.com

1.35k stars 567 forks source link

Add roster identifier to assignment repos endpoint #2439

Open d12 opened 5 years ago

d12 commented 5 years ago

https://github.com/education/classroom/pull/2404/ had to be reverted as it caused exceptions when a user had a roster + assignment repos by a user who wasn't on the roster. The fix is just conditionally grabbing the identifier off of the roster entry which may or may not exist. I broke tests by adding a second assignment repo by a user not on the roster, as seen here: https://travis-ci.org/education/classroom/jobs/600831209#L2145

https://github.com/education/classroom/pull/2439/commits/55c57fb79b3c18df0f143e9fcd7f4bbb5b64404f fixes it.

d12 commented 5 years ago

@jeffrafter All comments addressed, this is ready for review again!