search

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.35k stars 567 forks source link

Determine why broken javascript stopped entire assignment import #2447

Open JessRudder opened 5 years ago

JessRudder commented 5 years ago

Recently, a bug fix for search/sort JavaScript on Firefox resulted in a breakage of the ability to accept assignments on IE/Edge.

We need to identify why broken front end code would stop the assignment import process which is kicked off on the back end.

JessRudder commented 5 years ago

I've been digging into this and have been unable to recreate the same issue (even running the same code on Edge).

I do get the same JS error in console as before and the progress bars no longer work. However, the repo creation and import is still happening in the background which is not consistent with the previously reported error.

That said, the entire repo creation and import process is managed client-side in setup.js, so, it is reasonable to believe that JS problems could result in the import not working.

Would it make sense to move at least some of this server-side? Or should we leave it in the JS but make it more visible when something has broken?