github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 564 forks source link

Fix drop down menu on IE/Edge by getting proper JS and polyfills in place #2452

Closed JessRudder closed 4 years ago

JessRudder commented 4 years ago

The custom javascript for the details-menus used for search/filter on /classrooms was not working on IE/Edge.

This PR switches us over to using the Primer-provided js. Additionally, this adds polyfills which ensure these components work on browsers without web components (like certain versions of Edge and IE).

I've tested search/filter functionality and assignment acceptance functionality on: Edge 17/18 Chrome 78 Safari 13 Firefox 70