github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 564 forks source link

Invitation source changes per assignment accepted #2459

Open jameskinneavy opened 4 years ago

jameskinneavy commented 4 years ago

Describe the problem When an assignment invitation link is pasted into the browser by a student (or me simulating a student), the person receives an email invitation from one of the "Administrators" of the classroom, but it is not always the same one and, because of the fact that Administrators are global and not at the individual classroom level, this creates confusion for the

To Reproduce Steps to reproduce the behavior:

  1. Set up a classroom in an org that has multiple administrators
  2. Set up two assignments
  3. Using a test account, paste the link sequentially for each assignment into a browser tab to create the repository
  4. Check email: There should be an invitation for each assignment, but possibly from different or rotating administrators

Expected behavior

  1. First, I don't expect an email invitation to even occur if I provide the link externally through the LMS or paste into a browser. I would only expect email invitations if I imported my classroom from the LMS and then invited the class that way
  2. I expect the email to come from the creator of the assignment, not a random or rotating administraor

Screenshots Here are sequential assignments accepted in the space of a couple of minutes. Neither of the inviters are actually me (the author of the assignment), but are organizational admins (as am I)

image

image

d12 commented 4 years ago

Thanks for the report! We're looking into ways to make this less random, but for now, the administrator who adds the student to the assignment is not constant.