[WIP] Upgrade to Rails 6.0.1

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.

https://classroom.github.com

1.34k stars 564 forks source link

[WIP] Upgrade to Rails 6.0.1 #2472

Open JessRudder opened 4 years ago

JessRudder commented 4 years ago

We're upgrading to Rails 6.0.1! 🎉

Here's what needs to be done:

[ ] Check changelogs for upgraded gems for any gotchas:
- [ ] rails-i18n
- [ ] sass-rails
- [ ] sprockets (correct the quotes used here)
- [x] action-cable-testing
[ ] Make decision on encrpyted cookies
- 6.0.1 has new encrypted cookies that are more secure but if we use them, all the 5.2.X cookies will be invalidated as soon as we upgrade
[ ] Check that npm packages are correctly moved into the rails scope where necessary
TBD

renz45 commented 4 years ago

That ParameterFilter error is coming from rspec I believe, if you upgrade to gem 'rspec-rails', '>= 4.0.0.beta3' it should solve the issue.

I also didn't see any issues with sass/sprockets so far either 😄