search

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 566 forks source link

Assignment Forks Misattributing Template Repo Commits #2493

Closed brrcrites closed 4 years ago

brrcrites commented 4 years ago

Describe the bug GitHub Classroom assignments which are created with starter code and use the "Import starter code using a template repository" beta feature occasionally seem to incorrectly attribute authorship of the template repo's commits in the newly forked commit history (and contributor list) to a different author. This doesn't happen in every student submission fork of the template repository only a subset.

To Reproduce This issue has not presented on all student forked repos and I am unsure how to reproduce it.

Expected behavior When forking from a GitHub Classroom assignment link I would expect that the commits made to the template repo (compressed or otherwise) would appear in the students forked submission repo attributed to the original author.

d12 commented 4 years ago

Thanks for the report! I'm going to close this issue in favor of the earlier https://github.com/education/classroom/issues/2459