github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 566 forks source link

Update roster management (IA redesign) #2497

Open femmebot opened 4 years ago

femmebot commented 4 years ago

Part of IA redesign (tracking). Much of this functionality currently resides under Classroom > Settings > roster management but will now occupy its own top-level tab, Students. Refer to the Figma mockups (011.0 - 011.3) for details/context.

Students empty state

Selecting manual import or LMS option invokes a tabbed modal (see modal screens). Uses the nested teams icon from Marketing icons

Figma 011

011

Figma 011. 1

011  1

Modal showing LMS options

overlay-LMS

Modal showing manual import

overlay-manual

Students screen, populated

Figma 011. 2

011  2

Figma 011. 3

011  3

Addendum

Revise first-time user flow

Update the first-time user sequence so that users are prompted to create an assignment immediately after they create their first classroom since this is the logical first step. Adding TAs or students doesn't make sense if they don't have any assignments to manage and our research has shown that most (if not all) teachers typically skip/defer adding students and TAs/admins.

FTUX rev flow

stevecassidy commented 4 years ago

Thanks very much for this which will hopefully address the main frustrations in Classroom. Some comments:

  1. Making a change to an entry should update the entry and maintain the state of the filters and pagination - current behaviour flips back to the first page of the list. Support the workflow of working through the list from start to finish making updates as needed. Test on larger classes - mine are typically 200-300.

  2. Add a confirmation dialog on change of github association etc. Current version makes the change without confirmation then makes it hard to see you've made a mistake.

  3. Importing students manually - should have the option to ignore duplicate entries, otherwise to update a list I need to first find the new students then only upload them. I can see the reason for the new handling of duplicates (add a suffix) but my first encounter with it gave me almost all of the class doubled up.

d12 commented 4 years ago

All great suggestions @stevecassidy :) We'll do our best to address your points when we free up some engineering resources.