github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 566 forks source link

Users who have changed username cannot create assignments #2508

Open catherine-leung opened 4 years ago

catherine-leung commented 4 years ago

Describe the bug I have had 2 students this term who decided to change their github usernames (they were wanting to change it to something more professional). These two students cannot accept assignments via github classroom assignment links. I have tested this myself using another account and found that this seems to be case.

To Reproduce

  1. create a gropu assignment link (Mine were all group assignments, not sure if it is bugged for individual assignments)
  2. using an account that can accept the assignment, change the account's username
  3. use the assignment link to accept the assignment

Expected behavior You will get a pink "Resource could not be found on github.com " banner when you try to do so instead of being able to create the assignment.

d12 commented 4 years ago

Which specific students are impacted? While we work on a more long term fix, I can fix up their accounts in our system.

On Mon, Dec 23, 2019, 9:22 PM catherine-leung notifications@github.com wrote:

Describe the bug I have had 2 students this term who decided to change their github usernames (they were wanting to change it to something more professional). These two students cannot accept assignments via github classroom assignment links. I have tested this myself using another account and found that this seems to be case.

To Reproduce

  1. create a gropu assignment link (Mine were all group assignments, not sure if it is bugged for individual assignments)
  2. using an account that can accept the assignment, change the account's username
  3. use the assignment link to accept the assignment

Expected behavior You will get a pink "Resource could not be found on github.com " banner when you try to do so instead of being able to create the assignment.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/education/classroom/issues/2508?email_source=notifications&email_token=AHL44GE6EFKANBMNJCCFJCDQ2FW7LA5CNFSM4J6Z2EN2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICNV26A, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHL44GG3GFST3JGS6RHG27LQ2FW7LANCNFSM4J6Z2ENQ .

catherine-leung commented 4 years ago

I had manually added them to their repos and the course is over so its ok for now I think. Just wanted to report the issue.

bwiernik commented 4 years ago

I am currently having this problem. The user account for @ElisaCarsten is not listed in my classroom, only the only name for the account @ElisaCarsten2. When she clicks an assignment link, it shows the "Congratulations" message, but doesn't make a new repo or link her current account name to her name in the Student roster.

ZhenyuLiu46 commented 4 years ago

I have the same problem. I had to change back to my previous name and that solves the problem.

d12 commented 4 years ago

@ZhenyuLiu46 :wave:! If you'd like to change your GitHub login, I can fix up your Classroom account for you. After changing, just reach out to me here and I'll sort it out ASAP :)