Change Sidekiq queues to critical, default and low only. For efficiency

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.

https://classroom.github.com

1.34k stars 566 forks source link

Change Sidekiq queues to critical, default and low only. For efficiency #2518

Open gustavosobral opened 4 years ago

gustavosobral commented 4 years ago

What

It creates three queues (critical, default, and low) and assign all the workers to it.

From Sidekiq documentation:

I don't recommend having more than a handful of queues. Lots of queues makes for a more complex system and Sidekiq Pro cannot reliably handle multiple queues without polling. M Sidekiq Pro processes polling N queues means O(M*N) operations per second slamming Redis. https://github.com/mperham/sidekiq/wiki/Advanced-Options#queues

Closes #1381

andrewbredow commented 4 years ago

@JessRudder Adding you as reviewer because I think this is moda-focused. Feel free to redirect if not.