github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 566 forks source link

Canvas Integration Configuration 404 #2528

Closed lizfischer closed 4 years ago

lizfischer commented 4 years ago

Describe the bug When opening an assignment in Canvas set to open with GitHub Classroom, there is a 404 error. The link from the 404 page that says "Go back to classroom dashboard" results in "classroom.github.com refused to connect."

To Reproduce

  1. Follow the instructions for setting up Canvas integration. (Note here: the language in the documentation does not match the current interfaces. Canvas calls the URL field "Launch URL" and the GitHub configuration calls it "Application Auto-Configuration URL")

  2. Create a Canvas assignment with the Submission Type set to External Tool. Use Find to select GitHub Classroom. This error whether or not "Load This Tool In A New Tab" is selected.

  3. Save the assignment.

  4. Navigate to the assignment page.

Expected behavior The assignment page displays a GitHub classroom page (I've never seen this working so I'm not sure what it should do, exactly), or (if Load This Tool In A New Tab was selected) the "Load in a new window" button does the same.

Screenshots Integration setup image

Assignment settings image

Assignment page image.

lizfischer commented 4 years ago

Apologies if I'm just missing something here...

womenpower19111 commented 4 years ago

The fucWhy is it that GitHub is harassing me i have been trying and trying to inscribe from you services because i simply am not going to use GitHub for an thing in my position so het the fuck shit away from me i am feed up with it now what's its going take you sorry motherfuckers

Sent from Yahoo Mail on Android

On Sun, Jan 19, 2020, at 5:59 PM, Liz Fischernotifications@github.com wrote:
Describe the bug When opening an assignment in Canvas set to open with GitHub Classroom, there is a 404 error. The link from the 404 page that says "Go back to classroom dashboard" results in "classroom.github.com refused to connect."

To Reproduce

Expected behavior The assignment page displays a GitHub classroom page (I've never seen this working so I'm not sure what it should do, exactly), or (if Load This Tool In A New Tab was selected) the "Load in a new window" button does the same.

Screenshots Integration setup

Assignment settings

Assignment page .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

lizfischer commented 4 years ago

The fucWhy is it that GitHub is harassing me i have been trying and trying to inscribe from you services because i simply am not going to use GitHub for an thing in my position so het the fuck shit away from me i am feed up with it now what's its going take you sorry motherfuckers Sent from Yahoo Mail on Android.

Hi @womenpower19111 -- you're probably watching this repository on GitHub... if you go to this link and there's a button near the top right that says "Unwatch" you can click it and change to "Not Watching" to stop notifications. image

You can also go to https://github.com/settings/notifications and uncheck things there to stop notifications for everything.

d12 commented 4 years ago

:wave: @lizfischer , right now the integration only supports roster imports which you'll find in the students tab of your Classroom. Until we build out that support for assignment integration, trying to embed Classroom in your assignments like this won't do anything super useful :)

lizfischer commented 4 years ago

Oh, that explains it! Thank you :)