search

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 570 forks source link

Students can easily link to wrong identifier, can't unlink #2542

Open amueller opened 4 years ago

amueller commented 4 years ago

Feature request :sparkles:

From my students experience, it looks like it's very easy to link an account to the wrong identifier. I assume a single click is enough. It would be better if this would require also clicking "ok" or similar. I had several students link to the wrong UNI. Once they link to the wrong identifier, they can't unlink. I had students link to random identifiers that they accidentally clicked on, and now I do not know how to find them in the roster and unlink them.

amueller commented 4 years ago

If you could help me unlink that would be great, the github account that doesn't know which identifier is linked to is ilica. I can't search the roster for that from what I can see, so it would be great if you could do that.

d12 commented 4 years ago

@amueller This is an interesting edge case we hadn't thought of, thanks for letting us know! We'll see what we can do here.

The identifier your student matched to was ipm2111.

amueller commented 4 years ago

This edgecase happened about 5 times in my class of 225 students ;) I think the most important take-away is to make the sign-up a two-click process instead of a one-click process.

amueller commented 4 years ago

It's happening more and more times, and together with the students not being able to figure out which identifier they are linked to, it's pretty tricky to fix, as I can't search for their github user accounts in the interface.

stevecassidy commented 4 years ago

I also see this often. I raised it last year in #2455. Once a student does this it means that the real owner of the identifier can't select it, compounding the problem. I then have to use the awful roster management interface to try to detangle the associations.

amueller commented 4 years ago

Indeed, and I think it's different from #377 which #2455 has been rolled into.

Generally I refrain from calling any OSS project awful unless I wrote it myself, though ;)

Have you experience #2550 by the way? Not sure how big your class is.

d12 commented 4 years ago

cc https://github.com/education/classroom/issues/2519#issuecomment-592734122

Posting here as well for folks discovering this issue, we've shipped a small improvement to this interface, it now asks students to verify they clicked the correct roster entry before continuing. Thank you both for your feedback, we really appreciate it. We're working on a new system some time soon!