New Assignment Creation Page Does not Work

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.

https://classroom.github.com

1.34k stars 570 forks source link

New Assignment Creation Page Does not Work #2545

Open waqarsaleem opened 4 years ago

waqarsaleem commented 4 years ago

Describe the bug The new assignment creation page, see below, has lost the following functionality

detect repository names from GitHub
allow custom prefix

To Reproduce Steps to reproduce the behavior:

Go to Create Individual Assignment
Click on pen icon next to repository prefix
Also enter repository name for starter code

Expected behavior

The custom prefix seems to get lost each time I come back to the page, e.g. to change some setting. This should not happen.
The starter code field does not automatically detect repository names. It should.
Sometimes, entering all the fields and clicking on 'Create Assignment' just reloads the page with some of the settings lost and no assignment created.
Other times, it gives a 404 error.

Additional context It seems the new page has been deployed without proper testing. Today is the assignment release data and I am panicking.

spinecone commented 4 years ago

Hi @waqarsaleem , I'm taking a look at these issues now. Have you been able to create any assignments despite the issues with the starter code and the custom prefix?

waqarsaleem commented 4 years ago

This is the first time I am seeing and using this page. I think an assignment did get created but that was with minimal settings for testing when regular creation failed. Its settings need to be changed, but I keep encountering the same issues when I try to edit it.

waqarsaleem commented 4 years ago

In case you need to check it, this is the assignment page, https://classroom.github.com/classrooms/49143948-cs-113-discrete-mathematics-spring-2020/assignments/cs113-sp20-hw2

waqarsaleem commented 4 years ago

Actually, I had not paid attention to the URL until I copied it here just now. The URL contains the custom prefix I want. The deadline was not set when creating the assignment but I think the source repository was. I will go ahead and share the invite link for now and will enter the deadline when the issues are resolved.

waqarsaleem commented 4 years ago

You will notice in the first screenshot above that the space for the prefix is shaded. That is the default behavior when I edit the created assignment. It gets populated with the default name when I click in the Assignment Title box. I would expect it to be populated with the stored custom prefix. The repository I entered for the started code is remembered but creating after setting the deadline either leads to a reload of the page or a 404.

spinecone commented 4 years ago

We've just deployed a revert to the changes on the assignment form and it should be working now. Let us know if you experience any other issues.