search

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 570 forks source link

When assignment invitation URL is disabled, display message on invitation page #2548

Open melvidoni opened 4 years ago

melvidoni commented 4 years ago

I have an organisation with multiple classrooms. I created all the private repos on the organisation, and then an assignment on the classroom.

After creating the assignment I unchecked the "Enable assignment invitation URL". Shared it with a test student, and they still can accept the repository.

Is there any fix for this?

Expected behaviour Students should not be able to accept the assignment if it is unchecked.

Screenshots

Related issues This has already been reported #1592 and #1750

d12 commented 4 years ago

@melvidoni The students will be shown the screen to accept the assignment, but if they click the green button, it will show an error saying that invitations are currently disabled. I just tried it out and it seems to still perform like that.

A feature request to say the invitations are disabled on the initial page makes sense to me though :+1:

melvidoni commented 4 years ago

@d12 Thank you very much! It does work like that, though it is highly unusual to have the disabled notification popping up later.

I do second that feature request!