search

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 565 forks source link

[group-assignment] 1 maintainer of GH org randomly added to created teams #2553

Open erikmd opened 4 years ago

erikmd commented 4 years ago

Describe the bug During the automated creation of GitHub-classroom repositories for group assignments, one teacher (maintainer) is randomly added to each created GitHub team.

Cc @jochy FYI

To Reproduce Steps to reproduce the behavior:

  1. Go to https://classroom.github.com/classrooms
  2. Click on an existing classroom within a GitHub organization (say, https://github.com/GHOrgName)
  3. Define a group assignment (e.g. like screenshot below, with 3 as the max. number of members)
  4. Share the corresponding invitation link (https://classroom.github.com/g/XXXXXXXX)
  5. Wait that the students create/join teams
  6. Look at the page https://github.com/orgs/GHOrgName/teams
Screenshot of the GitHub classroom configuration ![2020-02-07_18-56-41_Screenshot_configuration_GitHub_classroom](https://user-images.githubusercontent.com/10367254/74054352-2fb24100-49de-11ea-99fd-7b8eb21a4712.png)

Expected behavior The members of the teams match those of the group-assignment in https://classroom.github.com/classrooms/

Actual behavior: One teacher is randomly added to each of the created teams, so that for example I ended up being added to 4 teams (see screenshot below).

Screenshots in the particular case of:

2020-02-07_19-00-34_Screenshot_unexpectedly_added_to_these_teams

Anyway, if the behavior I described above is not a bug but the (new) expected behavior, as per the principle of least surprise I believe it'd be more natural to be able to customize this as an opt-in(?)

Additional context I don't know if this is related, maybe not, so in this case please ignore that last remark: during the session, one student was not able to join a team https://github.com/orgs/M2DL/teams/gmt through GitHub Classroom: when he clicked on "Join" an error message was triggered (we didn't make a screenshot of that, sorry)… so I had to add him manually in https://github.com/orgs/M2DL/teams/gmt/members

d12 commented 4 years ago

Unfortunately due to technical limitations of how GitHub Classroom is built at the moment, this has to be done. We're looking into possible ways to solve this sometime in the future though.

erikmd commented 4 years ago

@d12 OK I see; thanks for your reply!

But beyond the fact the current behavior is not intuitive, are you sure this couldn't also trigger an issue regarding the maximum-number-of-members-per-team if one select that constraint in the group assignment?

(as I said in my initial post, I had to manually add one student in a given group as he didn't manage to join this group by the invitation link… but I guess this could be an unrelated transient issue as this had not been experienced by other groups)

d12 commented 4 years ago

The maximum-number-of-members-per-team limit doesn't look at the number of people in the GitHub.com team, it uses an internal GitHub Classroom counter, so it should be unaffected. The issue you had sounds like it may have been a transient issue, please let us know if this happens again!