search

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 570 forks source link

Unable To Disable Invitations For Group Assignments #2555

Closed ahanmal closed 4 years ago

ahanmal commented 4 years ago

I am unable to disable invitations for group assignments. Toggling the checkbox results in the loading indicator loading indefinitely. Looking at the XHR call, it appeared that the toggle_invitations endpoint was returning a 404. Looking closely at the request URL and the page URL, it appears that the page was hitting .../assignments/ps7/toggle_invitations instead of .../group-assignments/ps7/toggle_invitations. Sure enough, running a cURL on the fixed url resulted in a successful toggling of the invitations.

TL;DR: The invitation endpoint for group assignments needs to be fixed so that it is group-assignments instead of assignments.

Thanks!

d12 commented 4 years ago

Thanks for the report, and nice debugging!! We've been a little tight on engineering lately and haven't gotten to dig into this yet, but this looks simple to fix. I'll update here when we've pushed something up to production.

On Sat, Feb 8, 2020, 11:17 AM Ahan Malhotra notifications@github.com wrote:

I am unable to disable invitations for group assignments. Toggling the checkbox results in the loading indicator loading indefinitely. Looking at the XHR call, it appeared that the toggle_invitations endpoint was returning a 404. Looking closely at the request URL and the page URL, it appears that the page was hitting .../assignments/ps7/toggle_invitations instead of .../group-assignments/ps7/toggle_invitations. Sure enough, running a cURL on the fixed url resulted in a successful toggling of the invitations.

TL;DR: The invitation endpoint for group assignments needs to be fixed so that it is group-assignments instead of assignments.

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/education/classroom/issues/2555?email_source=notifications&email_token=AHL44GA5FOMRQK77WG6ZYPTRB4AM7A5CNFSM4KR4NJDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IMAN3DQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHL44GBUDEBH5JLOUQYDJKDRB4AM7ANCNFSM4KR4NJDA .

ahanmal commented 4 years ago

Thanks!

d12 commented 4 years ago

@ahanmal All fixed up! Thanks for the report :)