search

github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 570 forks source link

Assignments with starter code show as "Submitted" even when students have not pushed changes. #2566

Open lizfischer opened 4 years ago

lizfischer commented 4 years ago

Describe the bug When assignments have starter code from which student repositories are created, assignments are marked as "Submitted" whether or not the student has pushed any of their own work. Because Classroom interprets the last commit before the deadline as a submission, the initial commit that populates the repositories with the starter code is counted.

To Reproduce Create an assignment with starter code. Set a deadline. Have students accept the assignment but not push any changes.

Expected behavior I would expect only students who have pushed their own work (>1 commit for assignments with starter code, > 0 for assignments without starter code) before the deadline to be counted as submissions.

Screenshots Actual image

Expected image

Additional context This seems related to but distinct from some of the items mentioned in https://github.com/education/classroom/issues/2488. Also possibly related to https://github.com/education/classroom/issues/1353

d12 commented 4 years ago

Hey @lizfischer , thanks for the report! We've added this to our list of things TODO, hopefully we'll fix this up soon.