github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 570 forks source link

Editing Autograding Test Case Results in Lost Newlines #2567

Closed sgzwach closed 4 years ago

sgzwach commented 4 years ago

Describe the bug If newlines are required as part of a test case in autograding, they are lost if a test case is edited. It seems they're not loaded back into the text area.

To Reproduce Steps to reproduce the behavior:

  1. Create a new assignment with autograding enabled.
  2. Add a generic Input/Output test case that includes newlines in the Expected Output text area.
  3. Click Create Assignment
  4. Click Edit Assignment
  5. Click the pencil next to a test case to edit it. Any newlines in the Expected Output text area will be gone.

Expected behavior Newlines should persist between test case changes.

Screenshots Expected when editing: image

Actual: image

Additional context N/A

d12 commented 4 years ago

Thanks! Added to our TODO to fix :)

d12 commented 4 years ago

Fixed!