github-education-resources / classroom

GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.
https://classroom.github.com
1.34k stars 570 forks source link

How to disable the Feedback PR? #2569

Closed hroncok closed 4 years ago

hroncok commented 4 years ago

Describe the bug Today, when I've created a new assignment in @3DprintFIT the following things happen that did not previously happen:

  1. two commits to master from a random member of our org happen in the repo, both with the "Setting up GitHub Classroom Feedback" commit message. First creates .github/.keep, the other one seems empty.
  2. a feedback branch with only the first commit from the above 3 a "Feedback" pull request.

To Reproduce Steps to reproduce the behavior:

  1. Crete a new individual assignment form a template repo.
  2. Click the assignment link.

Expected behavior Nothing special should happen unless I opt-in.

Screenshots

Template repo:

_

Student repo:

_

The Pull request:

_

Additional context

I believe your intentions are good, but this interferes with our existing workflow and the students will be confused by this.

d12 commented 4 years ago

@hroncok Hey! Sorry about that, we're working on a new feature and I accidentally turned it on to the world. I've fixed that up, you shouldn't get these PRs again until we launch.

Out of curiosity, how does the PR interfere with your workflow?

hroncok commented 4 years ago

In this case, we run Jenkins CI for every commit and open issues in the repo. Now students get unrelated issues. Also, they receive feedback in those automatic issues, not in an artificial PR.

(I am not saying we cannot adapt or use this to some benefit, but not so suddenly.)

hroncok commented 4 years ago

FTR this is now indeed not happening any more.

Good luck with the launch :shipit:

hroncok commented 4 years ago

And thanks for a super fast response.

d12 commented 4 years ago

Thanks for the info, we'll keep your workflow in mind :)